-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default server for ssl #105
Comments
This might be a issue in that the default SSL server block does not have a See https://github.com/jwilder/nginx-proxy#how-ssl-support-works |
There is no default SSL server block, like it is for non-ssl. That's because one needs the right certificates for the requested domain. Maybe there should be one garbage default server per domain registered for use with ssl by env . |
A fix for this would be really nice, because landing on the wrong virtual host when restarting a container (or using the server's IP address) is really confusing. What about having a _default.crt and _default.key in the certs volume, and a default SSL vhost using those files and always returning HTTP 503? Edit: The template already uses some default.crt and default.key, but that seems to be the fallback if no certificate is found for a vhost. |
As mentioned there is still no default SSL block to catch invalid SSL vhosts. |
This was fixed in #2186 |
If there are ssl-servers defined and one is requesting a non defined server, the request will be send to the first ssl server.
I change the nginx.tmpl on my own now, but I think there should be a possibility to set a standard ssl-server like you defined it for http/80?
The text was updated successfully, but these errors were encountered: