Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring ACME no redirection inline with companion #1409

Merged
merged 1 commit into from Mar 17, 2021

Conversation

buchdag
Copy link
Member

@buchdag buchdag commented Mar 20, 2020

Add the following to the Let's Encrypt ACME challenge "no redirection to HTTPS"

nginx-proxy/acme-companion#570
nginx-proxy/acme-companion#335

Add the following to the Let's Encrypt ACME challenge "no redirection to HTTPS"
nginx-proxy/acme-companion#570
nginx-proxy/acme-companion#335
@sgabe
Copy link
Contributor

sgabe commented Jun 8, 2020

Both auth_request off; and the ^~ modifier could save some headaches as discussed in the referenced threads. Both have been there in the companion container for quite some time now, without new issues, so LGTM.

@buchdag buchdag merged commit bf2d729 into master Mar 17, 2021
@buchdag buchdag deleted the no-https-redirect-acme branch March 17, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants