Remove scoped IPv6 addresses from resolvers (fix #1424) #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding IPv6 NAT, changes are coming to Docker:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #1424. It removes any scoped IPv6 addresses from RESOLVERS in docker-entrypoint.sh. The alternative fix is to remove the interface from the address, but this could result in the wrong interface being used as a resolver which seems more dangerous and less intuitive than simply removing the address all together.
I also updated the README addressing this change and included some details on IPv6 NAT in response to #1419.
make testhas one failure,test_dhparam_is_generated_if_missing, but this also fails on the master branch.