Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support LOG_FORMAT env variable. #2151

Merged
merged 3 commits into from
Jan 27, 2023
Merged

Support LOG_FORMAT env variable. #2151

merged 3 commits into from
Jan 27, 2023

Conversation

vincent-herlemont
Copy link
Contributor

@vincent-herlemont vincent-herlemont commented Jan 26, 2023 •
edited
Loading

Related to #2133

rhansen
rhansen requested changes Jan 26, 2023
View reviewed changes
Copy link
Collaborator

@rhansen rhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

nginx.tmpl Outdated Show resolved Hide resolved
test/test_log_format.py Outdated Show resolved Hide resolved
test/test_log_format.py Outdated Show resolved Hide resolved
test/test_log_format.yml Outdated Show resolved Hide resolved
test/test_log_format.yml Show resolved Hide resolved
test/test_log_format.yml Outdated Show resolved Hide resolved
@vincent-herlemont
Copy link
Contributor Author

vincent-herlemont commented Jan 27, 2023 •
edited
Loading

@rhansen Thanks for the review, I applied it.

rhansen
rhansen reviewed Jan 27, 2023
View reviewed changes
test/test_log_format.yml Outdated Show resolved Hide resolved
test/test_log_format.yml Outdated Show resolved Hide resolved
@rhansen rhansen merged commit 07cc80a into nginx-proxy:main Jan 27, 2023
@vincent-herlemont
Copy link
Contributor Author

@rhansen Thanks you! Did you know when is the next release with this feature is planned?

@vincent-herlemont vincent-herlemont deleted the add_log_format branch January 27, 2023 18:19
@rhansen
Copy link
Collaborator

rhansen commented Jan 27, 2023 •
edited
Loading

That's up to @buchdag, although you can use the latest tag which tracks main.

I forgot about updating the documentation. Would you mind opening a PR that mentions this new feature in README.md?

@buchdag buchdag added status/pr-needs-docs This PR needs new or additional documentation type/feat PR for a new feature labels Jan 27, 2023
@buchdag
Copy link
Member

buchdag commented Jan 27, 2023

@vincent-herlemont I'd like to have #1179 merged to complement #2146 before releasing a new version (and documentation for your PR's feature, as mentioned by @rhansen).

@vincent-herlemont vincent-herlemont mentioned this pull request Jan 27, 2023
Merged
@vincent-herlemont
Copy link
Contributor Author

@rhansen @buchdag Ok, follow up the documentation for this PR's feature #2152.

@SchoNie SchoNie mentioned this pull request Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhansen rhansen rhansen approved these changes

Assignees
No one assigned
Labels
status/pr-needs-docs This PR needs new or additional documentation type/feat PR for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vincent-herlemont @rhansen @buchdag