Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alpine image #408

Closed
wants to merge 1 commit into from
Closed

Add alpine image #408

wants to merge 1 commit into from

Conversation

chuangbo
Copy link

@chuangbo chuangbo commented Apr 5, 2016

Alpine linux is a tiny linux distribution which ideal for building
docker images.

for more commit details, this commit:

  • Build from nginx:alpine (nginx:alpine does not have versions)
  • Add full nginx.conf as nginx:alpine has a different nginx.conf then debian
  • Download forego in Dockerfile for better building caching
  • Change badge version ;-)

Fixed #292

Alpine linux is a tiny linux distribution which ideal for building
docker images.

for more commit details, this commit:

- Build from nginx:alpine (nginx:alpine does not have versions)
- Add full nginx.conf as nginx:alpine has a different nginx.conf then debian
- Download forego in Dockerfile for better building caching
- Change badge version ;-)
@hasufell
Copy link

hasufell commented Apr 5, 2016

Alpine runs musl libc and often with downstream patches on specific packages which may or may not be reviewed. It's unclear what the side effects of running musl system-wide are. But there are side effects.

@chuangbo
Copy link
Author

chuangbo commented Apr 5, 2016

Yes I agree. For the downstream compatibility we should release alpine to tag alpine but not latest.

matt-hh added a commit to matt-hh/nginx-proxy that referenced this pull request Sep 1, 2016
- Inspired by nginx-proxy#408
- Possible solution for nginx-proxy#543
matt-hh added a commit to matt-hh/nginx-proxy that referenced this pull request Sep 2, 2016
matt-hh added a commit to matt-hh/nginx-proxy that referenced this pull request Sep 2, 2016
- Inspired by nginx-proxy#408
- Possible solution for nginx-proxy#543
@jwilder
Copy link
Collaborator

jwilder commented Feb 16, 2017

Fixed via #558

@jwilder jwilder closed this Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants