-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added HTTPS_METHOD=nohttps to disable SSL site #590
Conversation
@lange for now you can use this trick: |
@jwilder This build is failing because Travis-CI is running a newer version of Docker than the one specified in your
I think it would be best to do 1 and 2, where we figure out the latest version in Travis, pin that one in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Can you rebase since #649 has been merged?
Sure, I'll rebase and push today. |
Thanks @kamermans! |
This feature complements
HTTPS_METHOD=nohttp
, which disables the HTTP site. For containers withHTTPS_METHOD=nohttps
set, the template setsis_https
tofalse
, which treats everything as if there was no matching certificate.This solves issue #573, in which a user needs to disable the HTTPS site for a specific container with a subdomain that happens to match the SSL cert of another container.
A test has also been added to cover this directive.