Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for unitctl #39

Open
danielledeleo opened this issue May 15, 2024 · 10 comments
Open

Add support for unitctl #39

danielledeleo opened this issue May 15, 2024 · 10 comments

Comments

@danielledeleo
Copy link

brew install should also install unitctl to the user's path. @avahahn has CI builds in-progress which may simplify this process.

@thresheek
Copy link
Member

Do we tie unitctl releases to unit releases?

Or will it be updated & released separately?

The reason I'm asking is that former or latter will probably dictate if we should provide a separate formula for unitctl or just stick it into unit just like we do with unitc/setup-unit

@danielledeleo
Copy link
Author

I'm not sure. Refer to this PR for specifics on that. nginx/unit#1265

@ac000
Copy link
Member

ac000 commented May 15, 2024

@thresheek

It will be tied to the Unit release....

@thresheek
Copy link
Member

OK, so we can just use the tarball to get the sources we'd need.

@danielledeleo
Copy link
Author

I mean sure, that's fine, but we already have Mac CI builds for both aarch64 and x86-64. Can we use those? You'll probably find that it's a pain in the butt to build unitctl on macOS with its Maven dependencies and such.

@danielledeleo
Copy link
Author

@thresheek

It will be tied to the Unit release....

The reverse is true. Separate release tags are cut for unitctl, so it’s not bound to a unit release. It should therefore be a separate formula.

@ac000
Copy link
Member

ac000 commented May 16, 2024

The reverse is true. Separate release tags are cut for unitctl, so it’s not bound to a unit release. It should therefore be a separate formula.

I double checked, unitctl will be tied to unit releases...

@avahahn
Copy link

avahahn commented May 16, 2024

It will in fact be tied to unit releases. We did originally design for separate unitctl tags, but judged having separate tags superfluous.

@avahahn
Copy link

avahahn commented Jun 14, 2024

@thresheek Is this currently prioritized for working on?
We have users who clearly want this:
nginx/unit#1298

@thresheek
Copy link
Member

I postponed this to until we actually have a Unit release with unitctl included. There is nothing to install yet as of Unit 1.32.1 tarball.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants