Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm: unit-http: should we replace the https package as well? #1025

Open
javorszky opened this issue Dec 12, 2023 · 0 comments
Open

npm: unit-http: should we replace the https package as well? #1025

javorszky opened this issue Dec 12, 2023 · 0 comments
Labels
z-needs Investigation 🔬 z-node-js Language-Module for JavaScript (Node.js)

Comments

@javorszky
Copy link
Contributor

Issue #1013 revealed a bug where imports with signature node:http weren't replaced.

The current npm package unit uses as a custom loader looks for the http and websocket packages. Node applications do have the option to import the https package as well, which also has a .listen() method.

Do we need to replace the built in node https package with a unit specific https package, or will the underlying http package take care of the unit specific functionality as well?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
z-needs Investigation 🔬 z-node-js Language-Module for JavaScript (Node.js)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danielledeleo @javorszky @tippexs