Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add buildah dockerfiles for build #2490

Closed
gattytto opened this issue Mar 15, 2022 · 6 comments
Closed

add buildah dockerfiles for build #2490

gattytto opened this issue Mar 15, 2022 · 6 comments
Labels
proposal An issue that proposes a feature request waiting for response Waiting for author's response

Comments

@gattytto
Copy link

gattytto commented Mar 15, 2022

hello, I don't use Docker at all in my setups, I do use cri-o and LXD for the cluster nodes (kubernetes) so it would come in hand to have Dockerfiles that can be used with buildah to include non-merged PR's (like the ipv6 one) before they reach release stage.

also when I try to use the Dockerfile from quay.io it won't work, I guess for the same reasons buildah doesn't. So this would be my first go-to platform if we have those kinds of Dockerfiles.

thank you in advance

@gattytto gattytto added the proposal An issue that proposes a feature request label Mar 15, 2022
@github-actions
Copy link

Hi @gattytto thanks for reporting!

Be sure to check out the docs while you wait for a human to take a look at this 🙂

Cheers!

@gattytto
Copy link
Author

Hi @gattytto thanks for reporting!

Be sure to check out the docs while you wait for a human to take a look at this 🙂

Cheers!

you are a bot, sir

@lucacome
Copy link
Member

Hi @gattytto

We heavily rely on multi-stage builds and I think our Dockerfile would work with buildah if it wasn’t for this containers/buildah#2469

We also have edge images that include the latest code in master, I'm not sure I would recommend using code from a PR, especially from work in progress like IPv6.

also when I try to use the Dockerfile from quay.io it won't work, I guess for the same reasons buildah doesn't. So this would be my first go-to platform if we have those kinds of Dockerfiles.

we're not pushing Docker images to quay.io at the moment, which Dockerfiles are you referring to? 🤔

@gattytto
Copy link
Author

we're not pushing Docker images to quay.io at the moment, which Dockerfiles are you referring to? 🤔

I mean trying to use the Dockerfile as is from my account and forked repo in quay.io doesn't take the multistage dockerfile either

@lucacome
Copy link
Member

@gattytto are you talking about repository builds in quay.io? If so it looks like they're not very configurable and you would need to pass a few parameters for the build to work anyway

@vepatel
Copy link
Contributor

vepatel commented Jan 15, 2024

@lucacome can this issue be closed now?

@jjngx jjngx closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal An issue that proposes a feature request waiting for response Waiting for author's response
Projects
Archived in project
Development

No branches or pull requests

4 participants