Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not specify controller.nodeSelector using values.yaml #3683

Closed
mkhon opened this issue Mar 23, 2023 · 3 comments
Closed

Can not specify controller.nodeSelector using values.yaml #3683

mkhon opened this issue Mar 23, 2023 · 3 comments
Labels
waiting for response Waiting for author's response

Comments

@mkhon
Copy link

mkhon commented Mar 23, 2023

values-custom.yaml:

controller:
  nodeSelector:
    node-role.kubernetes.io/worker: "true"

Installation fails with the following error:

$ helm upgrade --install --dry-run v3 . -f values-custom.yaml
Error: UPGRADE FAILED: values don't meet the specifications of the schema(s) in the following chart(s):
nginx-ingress:
- controller.nodeSelector: nodeSelectorTerms is required

I am not sure the definition of nodeSelector in values.schema.json is correct. If I remove $ref there the installation succeeds.

@github-actions
Copy link

Hi @mkhon thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@coolbry95
Copy link
Contributor

I believe you are running into this issue #3449.

This will be fixed in 3.1.0 which is going to be release soon. #3685

@lucacome
Copy link
Member

@mkhon this should be fixed in https://github.com/nginxinc/kubernetes-ingress/releases/tag/v3.1.0 let us know if it works for you

@lucacome lucacome added the waiting for response Waiting for author's response label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for response Waiting for author's response
Projects
Archived in project
Development

No branches or pull requests

4 participants