Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate conformance report and upload to release #1017

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

sjberman
Copy link
Contributor

Problem: We want to be able to upload our conformance report for every release, so we can keep the upstream Gateway API tracker for our project up to date.

Solution: Generate the conformance report whenever the tests are run. When a release occurs, we'll upload to the release artifacts.

Testing: Created a release on my fork and verified that the conformance profile was uploaded.

Closes #961

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Problem: We want to be able to upload our conformance report for every release, so we can keep the upstream Gateway API tracker for our project up to date.

Solution: Generate the conformance report whenever the tests are run. When a release occurs, we'll upload to the release artifacts.
@sjberman sjberman requested a review from a team as a code owner August 30, 2023 17:46
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies Pull requests that update a dependency file labels Aug 30, 2023
.github/workflows/conformance.yml Outdated Show resolved Hide resolved
.github/workflows/conformance.yml Show resolved Hide resolved
@sjberman
Copy link
Contributor Author

@kate-osborn Is summary necessary? You mentioned it in the ticket that we have to manually add it. Just wondering if we need it.

@kate-osborn
Copy link
Contributor

@kate-osborn Is summary necessary? You mentioned it in the ticket that we have to manually add it. Just wondering if we need it.

There was some talk back on a conformance profile PR into the community about requiring summaries, but looking at the committed conformance reports, it doesn't look like they enforce that at all. It's kind of a weird field, not sure how we would generate a meaningful summary anyway.

@sjberman sjberman merged commit 921dd00 into nginxinc:main Aug 30, 2023
22 checks passed
@sjberman sjberman deleted the chore/conformance-profile branch August 30, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Generate conformance report for NKG at each release
3 participants