Support processing multiple HTTP listeners #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
force-pushed
the
feature/listeners
branch
2 times, most recently
from
2b01152
to
d51ee8e
Compare
pleshakov
force-pushed
the
feature/listeners
branch
from
d51ee8e
to
ac5c0d9
Compare
kate-osborn
requested changes
Jun 1, 2022
pleshakov
force-pushed
the
feature/listeners
branch
from
ac5c0d9
to
cc2fb56
Compare
kate-osborn
approved these changes
Jun 3, 2022
pleshakov
force-pushed
the
feature/listeners
branch
from
cc2fb56
to
a9f91c1
Compare
This was referenced Jun 6, 2022
Problem: The Gateway needs to process a Gateway resource. Currently, that is already supported by the 'state' package. However, that support is limited. For example, the package doesn't allow processing multiple listeners. More over, the approach used in the 'state' package is hard to extend to support multiple listeners. This prompts development of a better solution. As a first deliverable, we want to support processing multiple HTTP listeners assuming they all bind to port 80. We also assume that the Gateway only supports a single Gateway resource with known namespace and name. Solution - replace the existing types of the state package with the new ones: - Introduce Configuration, which is an internal representation of the Gateway configuration. - Introduce Statuses, which holds status-related information about processed resources. - Introduce ChangeProcessor, which processes changes to Gateway API resources and returns new Configuration and Statuses.
pleshakov
force-pushed
the
feature/listeners
branch
from
5f9adae
to
c91771f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
The Gateway needs to process a Gateway resource. Currently, that is
already supported by the 'state' package. However, that support is
limited. For example, the package doesn't allow processing multiple
listeners. More over, the approach used in the 'state' package is hard
to extend to support multiple listeners.
This prompts development of a better solution.
As a first deliverable, we want to support processing multiple HTTP
listeners assuming they all bind to port 80.
We also assume that the Gateway only supports a single Gateway resource
with known namespace and name.
Solution - replace the existing types of the state package with
the new ones:
Gateway configuration.
processed resources.
resources and returns new Configuration and Statuses.