Handle multiple Gateway resources #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
force-pushed
the
feature/multiple-gateways
branch
from
0a2e932
to
8001f15
Compare
Previously, NGINX Gateway only supported a single Gateway resource that must have had 'nginx-gateway/gateway' namespace/name. This commit removes that hard-corded requirement: Now NGINX Gateway will select the Gateway resource among all resources that belong to NGINX Gateway (i.e. reference NGINX Gateway corresponding GatewayClass). In case of multiple Gateway resources, NGINX Gateway will use a deterministic conflict resolution strategy: it will choose the oldest resource based on the creation timestamp. If the timestamps are equal, NGINX Gateway will chose the resource that appears alphabetically first based on its namespace and then name.
pleshakov
force-pushed
the
feature/multiple-gateways
branch
from
8001f15
to
65ee71d
Compare
kate-osborn
requested changes
Jul 12, 2022
f5yacobucci
reviewed
Jul 14, 2022
f5yacobucci
reviewed
Jul 14, 2022
f5yacobucci
reviewed
Jul 14, 2022
f5yacobucci
approved these changes
Jul 18, 2022
kate-osborn
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previously, NGINX Gateway only supported a single Gateway resource
that must have had 'nginx-gateway/gateway' namespace/name.
This PR removes that hard-corded requirement: Now NGINX Gateway will
select the Gateway resource among all resources that belong to
NGINX Gateway (i.e. reference NGINX Gateway corresponding GatewayClass).
In case of multiple Gateway resources, NGINX Gateway will use a
deterministic conflict resolution strategy: it will choose the oldest
resource based on the creation timestamp. If the timestamps are equal,
NGINX Gateway will chose the resource that appears alphabetically first
based on its namespace and then name.