Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push release build to registry and create draft release. #146

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Push release build to registry and create draft release. #146

merged 1 commit into from
Aug 4, 2022

Conversation

pammecrandall
Copy link
Contributor

@pammecrandall pammecrandall commented Jul 18, 2022

Proposed changes

  • Creates a draft github release on a release branch and pushes the docker image to github container registry on a release tag.
  • Pushes the docker image to github container registry on a release tag.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the plan to create release branches? It might be overkill at this point in the project 🤔

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/release.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
and pushes the docker image to github container registry on a release tag.
@pammecrandall pammecrandall merged commit bf34e2f into nginxinc:main Aug 4, 2022
@lucacome lucacome added the chore Pull requests for routine tasks label Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants