Process all relevant cluster resources at start #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
force-pushed
the
feature/batch-events
branch
2 times, most recently
from
281e342
to
9501170
Compare
Problem: At start, the Gateway generates the first NGINX configuration (and a few subsequent ones) before it processed all relevant cluster resources. Such configuration is incomplete and should not be generated. For clients it means they can see transient 404 errors when NGINX is configured with such configuration. Solution: When the Gateway starts, it will generate the first NGINX configuration based on processing all relevant cluster resources.
pleshakov
force-pushed
the
feature/startup-event-processing
branch
from
888d883
to
199e3cb
Compare
f5yacobucci
reviewed
Aug 16, 2022
f5yacobucci
reviewed
Aug 16, 2022
f5yacobucci
reviewed
Aug 16, 2022
f5yacobucci
reviewed
Aug 16, 2022
f5yacobucci
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
At start, the Gateway generates the first NGINX configuration (and
a few subsequent ones) before it processed all relevant cluster resources.
Such configuration is incomplete and should not be generated. For clients
it means they can see transient 404 errors when NGINX is configured with
such configuration.
Solution:
When the Gateway starts, it will generate the first NGINX configuration
based on processing all relevant cluster resources.