Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changelog #204

Merged
merged 6 commits into from
Aug 19, 2022
Merged

Add changelog #204

merged 6 commits into from
Aug 19, 2022

Conversation

pleshakov
Copy link
Contributor

Proposed changes

  • since this an initial release, the changelog doesn't include granular things like changes, enhancements, bug fixes and stuff -- only the highlights of what was added.
  • it targets the release branch, so that it doesn't get published before the release. However, we will need to add it to the main branch after the release. At the same time, if you think adding this to the main branch is not a problem, I can update the PR.

@pleshakov pleshakov requested a review from a team August 19, 2022 17:23
kate-osborn
kate-osborn requested changes Aug 19, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
pleshakov and others added 4 commits August 19, 2022 12:19
@pleshakov @kate-osborn
Update CHANGELOG.md
84539bd 
Co-authored-by: kate-osborn <50597707+kate-osborn@users.noreply.github.com>
@pleshakov @kate-osborn
Update CHANGELOG.md
5a7d9ab 
Co-authored-by: kate-osborn <50597707+kate-osborn@users.noreply.github.com>
@pleshakov
Fix the links
ce18149
@pleshakov
Update compatibility
52c9a16
kate-osborn
kate-osborn approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

f5yacobucci
f5yacobucci reviewed Aug 19, 2022
View reviewed changes
CHANGELOG.md Outdated
COMPATIBILITY:
- The Gateway API version: `0.5.0`
- NGINX version: `1.21.3`
- Kubernetes version: `1.16+`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we tested it this far back?

@pleshakov pleshakov merged commit e87a7ca into release-0.1 Aug 19, 2022
@pleshakov pleshakov deleted the docs/add-changelog branch August 19, 2022 21:11
@lucacome lucacome added the documentation Improvements or additions to documentation label Aug 19, 2022
pleshakov added a commit that referenced this pull request Aug 22, 2022
@pleshakov
Add changelog (#204)
0cfcaf3 
Co-authored-by: kate-osborn <50597707+kate-osborn@users.noreply.github.com>
(cherry picked from commit e87a7ca)
@pleshakov pleshakov added the skip-changelog Pull requests that don't need to be added to the changelog. label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f5yacobucci f5yacobucci f5yacobucci approved these changes

@kate-osborn kate-osborn kate-osborn approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation skip-changelog Pull requests that don't need to be added to the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pleshakov @f5yacobucci @kate-osborn @lucacome