Remove redundant warnings #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warnings reported by dataplane.BuildConfiguration() are now redundant - they are reported as Conditions in the statuses of Gateway API resources, which includes warnings-related cases for: * invalid listener in an HTTPRoute * unresolved backend ref an HTTPRoute This commit removes the code, which generates and reports warnings. Additionally, the commit fixes a related test TestBuildConfiguration case "invalid listener": if a listener is invalid, it cannot include any Routes and AcceptedHostnames, so those fields are removed. Fixes #467
kate-osborn
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warnings reported by dataplane.BuildConfiguration() are now redundant - they are reported as Conditions in the statuses of Gateway API resources, which includes warnings-related cases for:
This PR removes the code, which generates and reports warnings.
Additionally, the PR fixes a related test TestBuildConfiguration case "invalid listener": if a listener is invalid, it cannot include any Routes and AcceptedHostnames, so those fields are removed.
Fixes #467