Simplify hostname validation for HTTPRoute #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
added
the
area/httproute/core
Commit 52fab05 added HTTPRoute validation, which included both data-plane agnostic and data-plane specific (NGINX) rules for hostnames. After recent team discussion, we concluded that the data-plane specific rules are not needed, as the agnostic rules provide sufficient validation and ensure support across data planes.
pleshakov
force-pushed
the
chore/simplify-hostname-validation
branch
from
646668a
to
00c3978
Compare
kate-osborn
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 52fab05 added HTTPRoute validation, which included both data-plane agnostic and data-plane specific (NGINX) rules for hostnames.
After recent team discussion, we concluded that the data-plane specific rules are not needed, as the agnostic rules provide sufficient validation and ensure support across data planes.