Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move BackendGroup to dataplane package #601

Merged
merged 2 commits into from
May 9, 2023
Merged

Move BackendGroup to dataplane package #601

merged 2 commits into from
May 9, 2023

Conversation

kate-osborn
Copy link
Contributor

Moves BackendGroup from the graph package to the dataplane package. This removes the graph dependency from the nginx/config package.

Fixes #468

@kate-osborn kate-osborn added the tech-debt Short-term pain, long-term benefit label Apr 28, 2023
@kate-osborn kate-osborn requested a review from a team as a code owner April 28, 2023 16:35
@kate-osborn kate-osborn requested review from pleshakov, mkingst and sjberman and removed request for mkingst April 28, 2023 16:35
pleshakov
pleshakov requested changes Apr 28, 2023
View reviewed changes
internal/state/dataplane/configuration.go Show resolved Hide resolved
internal/state/dataplane/configuration.go Outdated Show resolved Hide resolved
internal/state/dataplane/configuration.go Outdated Show resolved Hide resolved
internal/state/dataplane/configuration.go Outdated Show resolved Hide resolved
internal/state/dataplane/configuration.go Show resolved Hide resolved
internal/state/change_processor_test.go Outdated Show resolved Hide resolved
internal/state/dataplane/configuration.go Show resolved Hide resolved
internal/state/change_processor_test.go Outdated Show resolved Hide resolved
internal/state/dataplane/configuration_test.go Outdated Show resolved Hide resolved
internal/state/graph/httproute.go Outdated Show resolved Hide resolved
@kate-osborn kate-osborn requested a review from pleshakov May 2, 2023 19:05
pleshakov
pleshakov reviewed May 8, 2023
View reviewed changes
internal/state/graph/backend_refs.go Outdated Show resolved Hide resolved
internal/state/dataplane/configuration_test.go Outdated Show resolved Hide resolved
@kate-osborn kate-osborn requested a review from pleshakov May 9, 2023 16:03
@kate-osborn kate-osborn force-pushed the tech-debt/move-backend-group branch from b184469 to 512de1a Compare May 9, 2023 20:44
@kate-osborn kate-osborn requested a review from pleshakov May 9, 2023 20:59
@kate-osborn kate-osborn merged commit da3afad into main May 9, 2023
12 checks passed
@kate-osborn kate-osborn deleted the tech-debt/move-backend-group branch May 9, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@sjberman sjberman Awaiting requested review from sjberman

Assignees
No one assigned
Labels
tech-debt Short-term pain, long-term benefit
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor BackendGroups
2 participants
@kate-osborn @pleshakov