Set ResolvedRefs condition to true on HTTPRoutes #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
|
So by default we set to true, and then will override if a false case applies? |
Yes |
sjberman
approved these changes
May 16, 2023
pleshakov
approved these changes
May 16, 2023
Previously, the ResolvedRefs condition was only set to False on HTTPRoutes when one or more references could not be resolved. With this commit, ResolvedRefs will be set to true when all references are resolved.
kate-osborn
force-pushed
the
feat/resolved-ref-true
branch
from
18c135f
to
5ebf8db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the ResolvedRefs condition was only set to False on HTTPRoutes when one or more references could not be resolved. With this commit, ResolvedRefs will be set to true when all references are resolved.
Closes #611