Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GoReleaser config #722

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Update GoReleaser config #722

merged 3 commits into from
Jun 7, 2023

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Jun 7, 2023 •
edited

Proposed changes

Changes:

  • Updates the configuration to remove '--rm-dist' deprecated flag
  • Adds announce section to announce releases in the NGINX Community slack
  • Removes release section that was limiting the uploads to the binaries
  • Changes extension of SBOM artifacts from .sbom to spdx.json to better represent the content of the file (.sbom is an extension that devs at GoReleaser came up with and not standard)
  • Adds section to automatically close a milestone on release
  • Adds section to override the version that is injected in the binary for snapshot builds. These are all the builds that are not an official release.

Closes #700

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@lucacome
Update GoReleaser config
1714428 
Changes:
- Updates the configuration to remove '--rm-dist' deprecated flag
- Adds announce section to announce releases in the NGINX Community
  slack
- Removes release section that was limiting the uploads to the binaries
- Changes extension of SBOM artifacts from .sbom to spdx.json to better
  represent the content of the file (.sbom is an extension that devs at
GoReleaser came up with and not standard)
- Adds section to automatically close a milestone on release
- Adds section to override the version that is injected in the binary for
  snapshot builds. These are all the builds that are not an official
release
@lucacome lucacome requested a review from a team as a code owner June 7, 2023 01:39
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 7, 2023
@lucacome lucacome enabled auto-merge (squash) June 7, 2023 21:23
@lucacome lucacome self-assigned this Jun 7, 2023
@lucacome lucacome merged commit dc7dcfa into nginxinc:main Jun 7, 2023
12 checks passed
@lucacome lucacome deleted the chore/update-goreleaser branch July 18, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update GoReleaser settings
3 participants
@lucacome @sjberman @ciarams87