Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare OSS Files #76

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Prepare OSS Files #76

merged 1 commit into from
Mar 30, 2022

Conversation

kate-osborn
Copy link
Contributor

  • Updates the README to include current build and deploy instructions.
  • Adds license, contributing guidelines, code of conduct, pull request template, and the CLA agreement.
  • Makes the registry PREFIX used in make container configurable by user.
  • Adds a README to the cafe example with instructions on how to deploy.

pleshakov
pleshakov reviewed Mar 25, 2022
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kate-osborn
Looks good. Got a few suggestions and comments

LICENSE Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@f5yacobucci
Copy link
Contributor

LGTM once comments are resolved.

@kate-osborn
Prepare OSS Files
6435d40 
- Updates the README to include current build and deploy instructions.

- Adds license, contributing guidelines, code of conduct, pull request template, CODEOWNERS, and the CLA agreement.

- Makes the registry PREFIX used in make container configurable by user.

- Adds README to cafe example
@kate-osborn kate-osborn merged commit 72ad354 into nginxinc:main Mar 30, 2022
@pammecrandall pammecrandall added the enhancement New feature or request label Aug 9, 2022
@lucacome lucacome added documentation Improvements or additions to documentation chore Pull requests for routine tasks and removed enhancement New feature or request labels Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@f5yacobucci f5yacobucci Awaiting requested review from f5yacobucci

Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kate-osborn @f5yacobucci @pleshakov @pammecrandall @lucacome