Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate FakeCapturer #784

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

pleshakov
Copy link
Contributor

Proposed changes

Problem:
Generated FakeCapturer was out of date - it included removed methods from the Capturer interface.

Solution:
Regenerate FakeCapturer

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Problem:
Generated FakeCapturer was out of date - it included removed methods
from the Capturer interface.

Solution:
Regenerate FakeCapturer
@pleshakov pleshakov requested a review from a team as a code owner June 23, 2023 15:50
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 23, 2023
@pleshakov pleshakov merged commit 7fa6dff into nginxinc:main Jun 23, 2023
15 checks passed
@pleshakov pleshakov deleted the chore/update-generated-fakes branch June 23, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants