Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require conformance tests to succeed #846

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Require conformance tests to succeed #846

merged 1 commit into from
Jul 12, 2023

Conversation

sjberman
Copy link
Contributor

Now that we are API compliant, we should require conformance tests to pass on pull requests.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sjberman
Require conformance tests to succeed
c8cff2c 
Now that we are API compliant, we should require conformance tests to pass on pull requests.
@sjberman sjberman requested a review from a team as a code owner July 12, 2023 14:56
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 12, 2023
pleshakov
pleshakov approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@sjberman sjberman merged commit b7d421a into nginxinc:main Jul 12, 2023
16 checks passed
@sjberman sjberman deleted the chore/require-conformance branch July 12, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sjberman @pleshakov @ciarams87