Chores and refreshing dependencies #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Running with compat = 1.17 updates go.sum Updating to latest golang release for go.mod Updating CRDs after version changes requires deployment change Generated code contains differences Don't generate listers and informers if they are not used Solution: Ran through basic development workflows and updating most current changes
kate-osborn
approved these changes
Apr 4, 2022
pleshakov
reviewed
Apr 4, 2022
Note, update-codegen.sh uses positional arguments, the second argument is unused and intentionally left blank.
pleshakov
approved these changes
Apr 4, 2022
lucacome
added
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
Running with compat = 1.17 updates go.sum
Updating to latest golang release for go.mod
Updating CRDs after version changes requires deployment change
Generated code contains differences
Don't generate listers and informers if they are not used
Solution:
Ran through basic development workflows and updating most current
changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.