Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove njs-modules configmap #959

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

kate-osborn
Copy link
Contributor

Proposed changes

Problem: PR #934 did not remove the njs modules configmap from the manifests directory.

Solution: Remove the njs modules configmap.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@kate-osborn kate-osborn requested a review from a team as a code owner August 11, 2023 19:00
@github-actions github-actions bot added the bug Something isn't working label Aug 11, 2023
@sjberman
Copy link
Contributor

Looks like there are a couple more njs-modules references if you do a grep.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 11, 2023
@kate-osborn
Copy link
Contributor Author

Looks like there are a couple more njs-modules references if you do a grep.

Removed. Thanks for catching!

@kate-osborn kate-osborn merged commit d4ce16b into nginxinc:main Aug 11, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants