Integrate NGINX prometheus exporter and enable metrics server #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
sjberman
reviewed
Aug 24, 2023
pleshakov
previously requested changes
Aug 24, 2023
kate-osborn
requested changes
Aug 25, 2023
ciarams87
force-pushed
the
feat/add-prom-exporter
branch
from
51d7a86
to
35b306e
Compare
ciarams87
force-pushed
the
feat/add-prom-exporter
branch
from
35b306e
to
4200b37
Compare
sjberman
reviewed
Aug 25, 2023
kate-osborn
requested changes
Aug 25, 2023
sjberman
approved these changes
Aug 28, 2023
ciarams87
force-pushed
the
feat/add-prom-exporter
branch
from
79d796b
to
bb0157e
Compare
pleshakov
reviewed
Aug 29, 2023
kate-osborn
reviewed
Aug 29, 2023
ciarams87
force-pushed
the
feat/add-prom-exporter
branch
from
bb0157e
to
a829f9f
Compare
kate-osborn
approved these changes
Aug 30, 2023
ciarams87
force-pushed
the
feat/add-prom-exporter
branch
from
a829f9f
to
7cdc73b
Compare
sjberman
approved these changes
Aug 30, 2023
ciarams87
dismissed
pleshakov’s stale review
Dismissing due to PTO, comments have been addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: As an operator of NKG in a production environment
I want Prometheus metrics to be exposed for NKG
So that I can observe and monitor the performance of NKG and respond to incidents.
Solution: Enable the controller-runtime metrics server, integrate NGINX prometheus exporter, and add the NGINX metrics to the metrics server
Testing: Unit testing, manual testing for both http and https endpoints, on both exposing the endpoint directly to localhost, and on a prometheus server using the pod annotations
Closes #761
Checklist
Before creating a PR, run through this checklist and mark each as complete.