Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more setting request #5

Closed
NoName805 opened this issue Jul 25, 2018 · 5 comments
Closed

more setting request #5

NoName805 opened this issue Jul 25, 2018 · 5 comments

Comments

@NoName805
Copy link

Could you please add some settings as below config?

Because I have no idea to forward my site to my back-end https server? --> proxy_pass https://x.x.x.x/;.

I just modify the config file as below for make my site work now.

   location / {
	proxy_pass https://x.x.x.x/;
	proxy_http_version      1.1;
        proxy_set_header Connection "";
	proxy_read_timeout      360;
	proxy_pass_header       Date;
	proxy_pass_header       Server;
	proxy_pass_header       Authorization;
	proxy_set_header        Host $host;
	proxy_set_header        X-Real-IP $remote_addr;
	proxy_set_header        X-Forwarded-For  $proxy_add_x_forwarded_for;
	proxy_pass_request_headers on;
	proxy_set_header Accept-Encoding "";
	proxy_request_buffering off;
	proxy_buffering off;
	#proxy_set_header Connection "Keep-Alive";
	}

Many thanks.

@jc21
Copy link
Member

jc21 commented Jul 25, 2018

I do want to improve the functionality while maintaining an easy to understand interface. I think giving the ability to modify the config within the site will be the best option for this. It's pretty hard to support websockets upgrade for example as nearly every different site puts that in a different subpath.

@SGStino
Copy link

SGStino commented Sep 28, 2018

Perhaps the advanced configuration should by default show the entire server { } configuration contents, just automatically generated, and the variables from the first tab provided as $variables?

(so basically move the location / { } to the advanced configuration by default?)
As long as nobody goes to the advanced tab, it's still simple to use, but also more powerfull for more experienced users?

So far i've been able to do the websockets for most scenarios, except now for mosquitto. Where the root seems to be the websocket path.

@jc21
Copy link
Member

jc21 commented Sep 29, 2018

Yep I considered that as an option. In your case, it might be worth adding a option to enable websocket upgrades for the entire site, as the quickest solution. I've been considering that anyway and no reason why both ideas can't co-exist. I'll look in to it in a week

@jc21
Copy link
Member

jc21 commented Oct 1, 2018

This doesn't solve the original issue, but I've added another setting for Proxy Hosts in version 2.0.3 for any hosts that need websocket upgrades. Just turn on "Allow Websocket HTTP Upgrades" and hopefully everything works without the need for advanced config.

@chaptergy
Copy link
Collaborator

As custom nginx configuration for hosts and locations are possible, I think this issue does not have to stay open anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants