Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipywidgets 6 support #625

Closed
kain88-de opened this issue Jun 26, 2017 · 9 comments
Closed

ipywidgets 6 support #625

kain88-de opened this issue Jun 26, 2017 · 9 comments

Comments

@kain88-de
Copy link
Contributor

What is the current reason for nglview to not support ipywidets 6?
Is there a way others could help to make the transition?

@hainm
Copy link
Collaborator

hainm commented Jun 26, 2017

master branch does support ipywidgets 5, 6 and 7.

However, the ipywidgets 6 has bug(s) and it doesn't have stable API (some changed in v7).

@kain88-de
Copy link
Contributor Author

Is there any knows when the newest version will be out? It also looks like from the issue discussion as this was a bug in NGL.

My personal issue is that I'm starting to have to use nglviewer in a custom conda environment since other common widget packages all depend on ipywidgets6 now.

@hainm
Copy link
Collaborator

hainm commented Jun 26, 2017

Is there any knows when the newest version will be out?

how's about tonight (US time)?

@kain88-de
Copy link
Contributor Author

You mean a new version of nglviewer with conda packages that pin to ipywidgets 6? Sure I'm good with any date for that.

@hainm
Copy link
Collaborator

hainm commented Jun 26, 2017

The problem is that I don't want to support ipywidgets 6. It's a transition from old API v5 to more stable (new) API v7.

If you really want to try with ipywidgets 6, please use git version of nglview.
cheers.

@hainm
Copy link
Collaborator

hainm commented Jun 26, 2017

PS: I myself prefer to have an usable and stable software rather trying to experimenting bleeding-edge with lots of bugs.

@hainm
Copy link
Collaborator

hainm commented Jun 27, 2017

I just tried nglview master branch with ipywidgets v6 and the below bug still exists

debug

Note that we already have a fix for ipw v7: #618

So for now, no official support for ipywidgets 6.

@hainm hainm closed this as completed Jun 27, 2017
@hainm
Copy link
Collaborator

hainm commented Jun 27, 2017

Similar solution from beakerx:

twosigma/beakerx#5486

@hainm
Copy link
Collaborator

hainm commented Jul 16, 2017

The next release of nglview will be compatible with ipywidgets 7.

https://github.com/arose/nglview/pull/635/files#diff-b4ef698db8ca845e5845c4618278f29aR2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants