Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing file_filter_test.go #29

Closed
gnanderson opened this issue Aug 18, 2012 · 3 comments
Closed

Failing file_filter_test.go #29

gnanderson opened this issue Aug 18, 2012 · 3 comments

Comments

@gnanderson
Copy link
Contributor

Hi guys,

This is more of a heads up, I've not quite got to the bottom of the problem yet.

After some tweaks to our core Go package RPM spec file, I was comfortable enough to re-enable building our Go repos for some other distros. A mime based file_filter test failed for the following distros:

https://build.opensuse.org/project/monitor?project=devel:languages:go
  • CentOS 6
  • RHEL 6
  • ScientificLinux 6

Given that these three distro's are clones, I'll bet there's some problem with mime type detection on RHEL 6. If I find more, I'll update.

Cheers the noo,
Graham

@dgrijalva
Copy link
Contributor

It certainly does look like the go standard library mime package isn't finding working on those systems. That's not really a problem we should solve here, though it's worth opening a ticket on the go project.

I think we can get our tests passing by manually adding all of the types we care about to the lookup table. That's probably a better solution anyway as it removed environment specific dependencies from our tests.

@dgrijalva dgrijalva reopened this Aug 19, 2012
@dgrijalva
Copy link
Contributor

I don't have access to those OSs to verify the fix. Could you please run them again and let me know if it's fixed?

@gnanderson
Copy link
Contributor Author

The failing test now passes for all three platforms, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants