Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component override is broken if the overridden component does not have the same theme states as the overriding one #3

Open
gbdrummer opened this issue Jul 19, 2019 · 0 comments

Comments

@gbdrummer
Copy link
Contributor

If we have this theme:

anchor {
  @state initial {
    color: green;
  }
}

anchor-button {
  @state initial {
    background: green;
    color: white;
  }

  @state focus {
    outline: 0;
  }
}

Because anchor-button overrides anchor, a build-blocking error will be thrown because anchor-button has a focus state in its theme while anchor does not. The diffing algo should allow for non-shared states.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant