Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 14 support #79

Closed
sambernet opened this issue Oct 24, 2022 · 2 comments
Closed

Angular 14 support #79

sambernet opened this issue Oct 24, 2022 · 2 comments

Comments

@sambernet
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[X] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

Angular 13 is used for the project currently.
The README.md doesn't give any information about supported angular versions

Expected behavior

I am aware that the library package.json has a peer dependency towards angular 13+ - so it's possible the library works just fine with angular 14 (which is really cool and should be adopted by more angular 3rd party libs 👍 )

But I'm currently mapping out the migration path for a large project with a lot of dependencies, and I was wondering if cashew has already been tested with angular 14? Maybe somebody has experience migrating this already?

Then I thought it would be nice to actually provide angular compatiblity information in the main readme of the repository.

Alternatively upgrading the whole library to angular 14 would also resolve my question, of course 😁

Minimal reproduction of the problem with instructions

n/a

What is the motivation / use case for changing the behavior?

Angular 14 was released on June 02, 2022 and is becoming adopted more and more widely. In November we already expect ng15 to hit the road.
Cashew is one of the last libraries for my specific ng 14 upgrade that is not confirmed yet to be ng 14 compatible.

Environment

Angular 14

@NetanelBasal
Copy link
Member

Sounds good :) You're welcome to create a PR.

@sambernet
Copy link
Author

Dammit, you beat me to it 😂
Thanks 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants