Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🔥 Add food from LATAM #187

Merged
merged 2 commits into from Feb 16, 2022
Merged

feat: 🔥 Add food from LATAM #187

merged 2 commits into from Feb 16, 2022

Conversation

midudev
Copy link
Contributor

@midudev midudev commented Feb 14, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Getting random food from anywhere but LATAM.

What is the new behavior?

Add food from LATAM

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@rodrigo-funes-biasatti
Copy link

Nice feat

@jsrubianoj
Copy link
Contributor

This is urgently needed!

@rroblf01
Copy link

These are the necessary changes to be able to use this library correctly.

@Luichidev
Copy link

It was time to add more countries.

@josuerodcat90
Copy link

josuerodcat90 commented Feb 14, 2022

Please add, as soon as you can ❤️🙏🏻

@NetanelBasal
Copy link
Member

Check CI, please. It needs to use seed.

@leonardofrp5
Copy link

Great PR for LATAM 🔥

@theryansmee
Copy link
Collaborator

@midudev - This is a great PR!
The tests I wrote are a little less dynamic than I'd of liked, so when you add new items to the json file they fail. This is because the outcome of the seed changes.

All you need to do is run jest --watch and update the hard coded expected values on the failing tests.

Once that's done, this is good to merge 😊

@theryansmee
Copy link
Collaborator

(Make sure to pull from main first, as it looks like some other foods have gone in)

@NetanelBasal
Copy link
Member

@theryansmee can you merge and take care, please?

@theryansmee
Copy link
Collaborator

@theryansmee can you merge and take care, please?

Yeah sure. Let me take a look now 😊

@theryansmee theryansmee merged commit eefb4b9 into ngneat:main Feb 16, 2022
theryansmee added a commit that referenced this pull request Feb 16, 2022
@theryansmee theryansmee mentioned this pull request Feb 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants