Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fraction doesn't work on randAggregation #305

Closed
PumpedSardines opened this issue Sep 6, 2022 · 2 comments
Closed

fraction doesn't work on randAggregation #305

PumpedSardines opened this issue Sep 6, 2022 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@PumpedSardines
Copy link
Contributor

Is this a regression?

No

Description

When passing in the argument fraction to the function randAggregation nothing changes

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

Inputing

function Demo(props) {
  return <Preview source={() => randAggregation({ values: 5, fraction: 5 })}/>;
}

On the docs page will not provide fractions



### Please provide the environment you discovered this bug in

```true
On the docs page

Anything else?

No response

Do you want to create a pull request?

No

@PumpedSardines PumpedSardines changed the title fraction doesn't work randAggregation fraction doesn't work on randAggregation Sep 6, 2022
@NetanelBasal NetanelBasal added bug Something isn't working good first issue Good for newcomers labels Sep 16, 2022
@PumpedSardines PumpedSardines mentioned this issue Dec 17, 2022
3 tasks
@Parikshit-Hooda
Copy link
Contributor

Is this still an issue? Should we close this one as I see a PR got merged?

@shaharkazaz
Copy link
Contributor

@Parikshit-Hooda I think you are correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants