Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: group files into folder #340

Closed
wants to merge 4 commits into from

Conversation

kobenguyent
Copy link
Contributor

@kobenguyent kobenguyent commented Dec 22, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

  • Issue Number: N/A
  • Resolve #issueNumber

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz
Copy link

stackblitz bot commented Dec 22, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@kobenguyent
Copy link
Contributor Author

hey @NetanelBasal just let me know if you are okay with this approach, cause to me, it seems a bit tricky to find the json and implementation at some point.
image

@NetanelBasal
Copy link
Member

I'm pretty sure this will break the docs generator:

https://github.com/ngneat/falso/blob/main/docs-generator.js

@kobenguyent
Copy link
Contributor Author

I just tried with main branch and observed the error, may you advise?
image

@kobenguyent
Copy link
Contributor Author

[group-into-folders][~/Desktop/falso]$ npm run build

> falso@0.0.0 build
> nx build falso && npm run i18n && node ./post-build.js


> nx run falso:build

Bundling falso...
  index.esm.js 429.472 KB
  index.cjs.js 434.603 KB
⚡ Done in 8.80s

 ——————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

 >  NX   Successfully ran target build for project falso (9s)
 

> falso@0.0.0 i18n
> nx i18n falso


> nx run falso:i18n

Build locales for ar, de, es, fr, hi, ru, se, zh.
Bundling falso...
Bundling falso...
Bundling falso...
Bundling falso...
Bundling falso...
Bundling falso...
Bundling falso...
Bundling falso...
  index_es.esm.js 1.183 KB
  index_ru.esm.js 6.728 KB
  index_zh.esm.js 980 Bytes
  index_de.esm.js 3.449 KB
  index_fr.esm.js 1.213 KB
  index_ar.esm.js 1.112 KB
  index_hi.esm.js 1.144 KB
  index_se.esm.js 1.197 KB
  index_zh.cjs.js 1.281 KB
  index_ar.cjs.js 1.413 KB
  index_es.cjs.js 1.484 KB
  index_se.cjs.js 1.498 KB
  index_ru.cjs.js 7.036 KB
  index_fr.cjs.js 1.514 KB
  index_hi.cjs.js 1.445 KB
  index_de.cjs.js 3.813 KB
⚡ Done in 2.88s
⚡ Done in 2.88s
⚡ Done in 2.90s
⚡ Done in 2.90s
⚡ Done in 2.93s
⚡ Done in 2.94s
⚡ Done in 2.94s
⚡ Done in 2.97s

 ——————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

 >  NX   Successfully ran target i18n for project falso (3s)
 
Changed umd to cjs

@NetanelBasal okay, windows issue, I tried this on MacOS and worked fine. Are you okay to continue going with this approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants