feat: add factory for SpectatorForDirective #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const createHost = createHostDirectiveFactory(HighlightDirective); | ||
|
|
||
| // calculated styles not supported in JSDOM | ||
| xit('should change the background color', () => { |
There was a problem hiding this comment.
Oh, I removed it but the tests fail. I had to exclude these tests earlier because the toHaveStyle() matcher is not supported in Jest. It relies on getComputedStyle().getPropertyValue().
There was a problem hiding this comment.
There is a way to check if the user uses Jest and warn them that it will not work?
There was a problem hiding this comment.
We currently don't have a way to detect it. Let's see if another solution is possible, e.g. not relying on computed styles. Let's fix it in a separate PR.
NetanelBasal
approved these changes
Aug 19, 2019
dirkluijk
force-pushed
the
v4-directive-factory
branch
from
5108cfe
to
0ff4455
Compare
dirkluijk
force-pushed
the
v4-directive-factory
branch
from
0ff4455
to
ef885d6
Compare
dirkluijk
added a commit
that referenced
this pull request
Aug 19, 2019
dirkluijk
added a commit
that referenced
this pull request
Aug 19, 2019
dirkluijk
added a commit
that referenced
this pull request
Aug 19, 2019
dirkluijk
added a commit
that referenced
this pull request
Aug 26, 2019
dirkluijk
added a commit
that referenced
this pull request
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So what I basically did:
Spectatorto abstractDomSpectator(for querying, event dispatching, etc) in order to reuse itSpectatorForDirectivewhich contains stuff from bothSpectatorandSpectatorWithHostcomponentthis one has adirectiveinstance