feat(routing): add option to disable stubs and use RouterTestingModule #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkluijk
force-pushed
the
feature/disable-routing-stubs
branch
from
2e52be5
to
7ad0d86
Compare
|
Before merging and releasing, should we create a beta/RC release to test if this PR really fixes the original issue? |
|
@dirkluijk Yes, we can test it with the reproduction repo. It's in the original issue. |
| useFactory: () => | ||
| new ActivatedRouteStub({ | ||
| // this prevents the events property to be undefined | ||
| router.castToWritable().events = EMPTY; |
There was a problem hiding this comment.
What if someone needs to test the router events? They might register a subscription in the component and want to test it.
There was a problem hiding this comment.
Yeah, for now I assume that you should provide your own mock provider if you want to configure mocks more advanced.
There was a problem hiding this comment.
Can't we just do the following?
options.mockProvider(Router, {
events = new Subject();
emitRouterEvent(e) {
this.events.next(e)
}
});There was a problem hiding this comment.
all right, will do
There was a problem hiding this comment.
done, can you check again?
dirkluijk
force-pushed
the
feature/disable-routing-stubs
branch
from
19ede7e
to
8c4a624
Compare
NetanelBasal
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #179.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
ActivatedRouteStubdoes not work well withRouterTestingModuleandLocation.Issue Number: 179
What is the new behavior?
This PR provides a feature toggle. Example in README.
Does this PR introduce a breaking change?
Other information