Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svg-generator doesn't work #101

Closed
MarcinHenzel opened this issue Sep 26, 2022 · 3 comments
Closed

svg-generator doesn't work #101

MarcinHenzel opened this issue Sep 26, 2022 · 3 comments

Comments

@MarcinHenzel
Copy link

MarcinHenzel commented Sep 26, 2022

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x ] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[] Other... Please describe:

Current behavior

While genereting svg-generator I get this:
TypeError: (0 , svgo_1.optimize) is not a function at createTree (...\node_modules\@ngneat\svg-generator\tree.js:49:53) at createTree (...\node_modules\@ngneat\svg-generator\tree.js:25:30) at generateSVGIcons (...\node_modules\@ngneat\svg-generator\generator.js:19:47) at Object.<anonymous> (...\node_modules\@ngneat\svg-generator\index.js:9:34) at Module._compile (internal/modules/cjs/loader.js:1085:14) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10) at Module.load (internal/modules/cjs/loader.js:950:32) at Function.Module._load (internal/modules/cjs/loader.js:790:14) at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12) at internal/main/run_main_module.js:17:47

and ofc ts files are not generated.

Expected behavior

Ts files should be generated

Environment

"@angular/animations": "~13.2.5",
"@angular/cdk": "^13.2.5",
"@angular/common": "~13.2.5",
"@angular/compiler": "~13.2.5",
"@angular/core": "~13.2.5",
"@angular/forms": "~13.2.5",
"@angular/material": "^13.2.5",
"@angular/platform-browser": "~13.2.5",
"@angular/platform-browser-dynamic": "~13.2.5",
"@angular/router": "~13.2.5",
"@ngneat/svg-icon": "^4.1.0",
It also happened on old svg-icon version when angular 13.2.5 was newest so changing version didn't change anything

For Tooling issues:

  • Node version: 14.17.3
  • Platform: Windows

Others:
npm list @ngneat/svg-icon doesn't provide any information.
When i log svgo_1.optimize I get undefined

@NetanelBasal
Copy link
Member

What is your svgo version?

@MarcinHenzel
Copy link
Author

MarcinHenzel commented Nov 1, 2022

I was usign 2.8.0, but also tried 3.0.0 and 1.3.2 - same result.
My svgo config is very basic:
"svgGenerator": {
"outputPath": "./src/app/svg",
"prefix": "app",
"srcPath": "./src/assets/svg",
"svgoConfig": {
"plugins": [
{
"removeDimensions": true,
"cleanupAttrs": true
}
]
}
}

@NetanelBasal
Copy link
Member

I can't reproduce it. See if it happens on a new project, please.

@ngneat ngneat locked and limited conversation to collaborators Nov 3, 2022
@NetanelBasal NetanelBasal converted this issue into discussion #108 Nov 3, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants