docs(messageformat): cleanup docs and remove duplication #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the duplication of a code block in the readme
shaharkazaz
reviewed
Oct 13, 2019
| @@ -41,15 +41,6 @@ import { TranslocoMessageFormatModule } from '@ngneat/transloco-messageformat'; | |||
|
|
|||
| ``` | |||
|
|
|||
| It then enables support for the following within your i18n translation files: | |||
There was a problem hiding this comment.
why remove the usage example?
There was a problem hiding this comment.
It was duplicated.
The usage example is still in the readme.
If you check out the readme as it is now, you will see the usage example has been duplicated. I removed the second instance of it.
shaharkazaz
approved these changes
Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The readme for the messageformat plugin had a duplicate block of code.
What is the new behavior?
Removed duplicate code block.
Does this PR introduce a breaking change?