Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use until-destroy-migration? #215

Closed
ivanyurchenko1 opened this issue Oct 19, 2022 · 4 comments
Closed

How to use until-destroy-migration? #215

ivanyurchenko1 opened this issue Oct 19, 2022 · 4 comments

Comments

@ivanyurchenko1
Copy link

Hello. I'm trying to apply the migration as mentioned in the readme.

I added the package with this command:
npm i --save-dev @ngneat/until-destroy-migration

And now I'm trying to do
npx @ngneat/until-destroy-migration --base my/path
which doesn't do anything at all. No errors, no changes. I changed path to mine, also tried to run without path, as well as without --base prefix. Nothing is happening.

@arturovt
Copy link
Collaborator

Can you provide a minimal reproducible example?

@ivanyurchenko1
Copy link
Author

Sure. Create any project, let's say https://stackblitz.com/edit/angular-playground

Download it, do
npm i --save-dev @ngneat/until-destroy-migration
and try to apply the
npx @ngneat/until-destroy-migration --base my/path

The same happens - nothing is changed. No errors or anything.

image

@arturovt
Copy link
Collaborator

But what are you expecting to be done? The migration script is used to move the old view engine API to the new format. The view engine required ngOnDestroy to be declared on the class which is not required in Ivy.

@arturovt
Copy link
Collaborator

Closing as not an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants