Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with latest version (2.2.0) #3

Closed
catchshyam opened this issue Mar 24, 2018 · 6 comments
Closed

Error with latest version (2.2.0) #3

catchshyam opened this issue Mar 24, 2018 · 6 comments

Comments

@catchshyam
Copy link

catchshyam commented Mar 24, 2018

Hello,

Big thumbs up for the plugin, thank you.

With the latest version, I get the following warning with "ng serve". I have not tested with AOT mode yet.

WARNING in ./node_modules/ngx-take-until-destroy/dist/umd/take-until-destory.js
13:24-31 Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

On on app run, following error is thrown,

take-until-destory.js:13 Uncaught Error: Cannot find module "."
at webpackMissingModule (take-until-destory.js:13)
at eval (take-until-destory.js:13)
at eval (take-until-destory.js:19)
at Object../node_modules/ngx-take-until-destroy/dist/umd/take-until-destory.js (vendor.bundle.js:2762)

I am using RxJS version 5.5.6

Thanks.

@catchshyam catchshyam changed the title Warning in JIT build Error with latest version Mar 24, 2018
@catchshyam catchshyam changed the title Error with latest version Error with latest version (2.2.0) Mar 24, 2018
@NetanelBasal
Copy link
Member

Can you verify that it's happening only with the latest version, please?

@catchshyam
Copy link
Author

With the latest release, the issue is reproducible only with the pipe operator. When used with the this.destroyed subject, no compilation warning are seen and application runs fine.

On my other project, I am using the version 1.1.2 (by the way, I don't see that release in the release history anymore) and no errors there.

@NetanelBasal
Copy link
Member

I think I know what the problem is.

@NetanelBasal
Copy link
Member

Try with 2.2.1, please.

@catchshyam
Copy link
Author

Fixed!

You have been super responsive and helpful. Thank you

@webdevius
Copy link
Contributor

Oops 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants