-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend use-cases for custom destroy method #66
Comments
@artaommahe Hey. I've published |
@arturovt second case is fixed, thx. First one is still here - calling one of the destroy methods complete every stream, even that is bound to other destroy method |
Thanks for clarifying, will look tomorrow. |
@artaommahe |
@artaommahe If you find a time to check it and it works then close the issue, or ping me here if you find another one. Cheers. |
@arturovt it works, thank you. Finally we can replace our local operator with |
With current custom destroy method implementation there are some issues
Playground for both cases here
https://ng-run.com/edit/LxkqzZQCoAv8i1KRl7Uj?open=app%2Fsome.service.ts
having two destroy methods (for different streams) and calling one of them completes all other streams
cannot use operator for start-stop case when you need to unsubscribe (after new subscriptions) multiple times during service lifetime
(only first start/stop buttons now)
It's real world use-cases from our apps where are a lot of such singleton services with start/stop methods for some pages business-logic.
The text was updated successfully, but these errors were encountered: