Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CSS Validation Issue #885

Closed
3 tasks done
itshypon opened this issue Jun 24, 2023 · 4 comments
Closed
3 tasks done

[BUG] CSS Validation Issue #885

itshypon opened this issue Jun 24, 2023 · 4 comments
Assignees
Labels
area/accessibility This issue is related to an accessiblity fix. 🐞 bug This is a patch, generally fixing some bugs. gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 status: wip πŸ‘©πŸ»β€πŸ’» This issue/PR is actively being worked on.

Comments

@itshypon
Copy link

Description

At some part of code, values of CSS properties is not correct. I would like to fix it.

Screenshots

image

Browser πŸ₯¦

Brave

Checklist βœ…

  • I checked and didn't find similar issue
  • I have read the Contributing Guidelines
  • I am willing to work on this issue (blank for no)
@itshypon itshypon added status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 🐞 bug This is a patch, generally fixing some bugs. labels Jun 24, 2023
@github-actions
Copy link

Hello, @itshypon, thank you for opening an issue.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.


Give us a ⭐ to show some support
Happy OpenSource πŸš€

@tamalCodes
Copy link
Member

Great issue, i would put this on-hold right now and this can be worked on as soon as #892 is merged to the main branch. Putting this temporarily on hold.

@tamalCodes tamalCodes added status: on hold 🚦 This issue/PR is on hold/blocked for now as other issues/PRs needs to be merged before this. and removed 🐞 bug This is a patch, generally fixing some bugs. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jun 28, 2023
@ngoworldcommunity ngoworldcommunity locked and limited conversation to collaborators Jun 28, 2023
@tamalCodes
Copy link
Member

Hi @itshypon , you can start working on it.

Remember, Good PR makes you a Good contributor !

We at Milan work hard to maintain the structure, and use conventional Pull request titles and commits. Without a proper template for the PR, not following the guidelines and spam might get the pull request closed, or banned.

  • Please make sure that you have read our documentation on Commiting guidelines and Pull request guidelines.

  • Once you have done the changes you can request a review. If I suggest changes again, do those and request a review again.

  • Make sure you DO NOT modify the PR template that we have, use it as it is.

  • Last but not least, be patient. It takes a while to review the changes and get it merged.

@ngoworldcommunity ngoworldcommunity unlocked this conversation Aug 8, 2023
@tamalCodes tamalCodes added 🐞 bug This is a patch, generally fixing some bugs. status: wip πŸ‘©πŸ»β€πŸ’» This issue/PR is actively being worked on. area/accessibility This issue is related to an accessiblity fix. gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 and removed status: on hold 🚦 This issue/PR is on hold/blocked for now as other issues/PRs needs to be merged before this. labels Aug 8, 2023
@tamalCodes tamalCodes added the invite me to the organisation Sends an invitation to your community organisation. label Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

We just made a new organization, Invitation sent to join the GitHub Organisation. Welcome to the community πŸŽ‰

Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/MilanCommunity/people

@github-actions github-actions bot closed this as completed Aug 9, 2023
@tamalCodes tamalCodes removed the invite me to the organisation Sends an invitation to your community organisation. label Aug 9, 2023
@tamalCodes tamalCodes reopened this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/accessibility This issue is related to an accessiblity fix. 🐞 bug This is a patch, generally fixing some bugs. gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 status: wip πŸ‘©πŸ»β€πŸ’» This issue/PR is actively being worked on.
Projects
Status: Merged/Discarded
Development

No branches or pull requests

2 participants