Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize duplicate code in NIRPS_ETC.pyand NIRPS_ETC_script.py #2

Closed
vandalt opened this issue Feb 2, 2022 · 1 comment · Fixed by #4
Closed

Reorganize duplicate code in NIRPS_ETC.pyand NIRPS_ETC_script.py #2

vandalt opened this issue Feb 2, 2022 · 1 comment · Fixed by #4

Comments

@vandalt
Copy link
Contributor

vandalt commented Feb 2, 2022

There seems to be a lot of duplicate code between the two scripts. This does not affect the results, but to make the code easier to maintain, I can try to put the code common to both in a separate file in the next few weeks.

@ngrieves
Copy link
Owner

ngrieves commented Feb 3, 2022

Yes, these codes are basically identical except the script loops through the targets from the input file, this was just a fast way to create one code that outputs the plot and SNR/order and another that just gives overall SNR and RV values for a number of targets. Due to the time crunch I didn't remove any duplications. That sounds good though thank you Thomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants