feat(schematics): display provided path when displaying an error #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koumatsumoto
force-pushed
the
display-provided-path-when-displaying-an-error
branch
from
68d9729
to
e4488d9
Compare
koumatsumoto
force-pushed
the
display-provided-path-when-displaying-an-error
branch
from
e4488d9
to
66f9ba6
Compare
brandonroberts
requested changes
Jul 29, 2018
| @@ -57,7 +57,7 @@ export function findModuleFromOptions( | |||
| } else if (host.exists(modulePath + '/' + moduleBaseName + '.module.ts')) { | |||
| return normalize(modulePath + '/' + moduleBaseName + '.module.ts'); | |||
| } else { | |||
| throw new Error('Specified module does not exist'); | |||
| throw new Error(`Specified module path ${modulePath} does not exist`); | |||
There was a problem hiding this comment.
Run yarn copy:schematics after modifying files in the schematics-core folder so the changes are copied to the other packages.
There was a problem hiding this comment.
I understand and additionally commit its changes.
Please continue your review.
brandonroberts
approved these changes
Jul 29, 2018
brandonroberts
changed the title
brandonroberts
changed the title
koumatsumoto
deleted the
display-provided-path-when-displaying-an-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update error messages in schematics and schematics-core modules.
Please see the relavant issue.
Closes #1200