Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Effects): Wrap testing source in an Actions observable #121

Merged
merged 1 commit into from
Jul 19, 2017
Merged

fix(Effects): Wrap testing source in an Actions observable #121

merged 1 commit into from
Jul 19, 2017

Conversation

MikeRyanDev
Copy link
Member

Closes #117

@MikeRyanDev MikeRyanDev mentioned this pull request Jul 19, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.802% when pulling ee9153b on fix/effects-testing-source into 4b20e3f on master.

@brandonroberts brandonroberts merged commit bfdb83b into master Jul 19, 2017
@MikeRyanDev MikeRyanDev deleted the fix/effects-testing-source branch July 19, 2017 23:06
@brandonroberts brandonroberts mentioned this pull request Jul 24, 2017
Closed
@KevinOrfas
Copy link

I am not sure that issue is solve. I just run into that and just updated the ngrx again and checked the commit which apparently fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brandonroberts brandonroberts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MikeRyanDev @coveralls @KevinOrfas @brandonroberts