Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store devtools): export INITIAL_OPTIONS for consuming via provid… #2405

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

ttestman4
Copy link
Contributor

…er (#1470)

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
This enhancement allow large scale projects to pass options using providers

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Current behaviour force to pass config option via forRoot to StoreDev tools. This make large scale project, where library initialization is abstracted out to library project, difficult to pass the options

Closes # 1470

What is the new behavior?

Configuration options can be passed using angular providers to StoreDevtools

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 23, 2020

Preview docs changes for 396c221 at https://previews.ngrx.io/pr2405-396c221/

@brandonroberts brandonroberts merged commit 37f91db into ngrx:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants