Allow diferentiating selectors and selectors-with-props at runtime

[GregOnNet]

Hi,

thanks for providing NgRx and for putting that much effort into it for such a long time. I already did a lot of projects with it.

Describe any alternatives/workarounds you're currently using

The Library NgRx Ducks build dynamic facades.
One feature is that the helper bindSelectors consumes all selectors of a file and turns them automatically into consumable Observables.

// selectors.ts
export const books = createSelector(featureSelector, state => state.books);

// facade.ts
import * as selectors from './selectors.ts'

@StoreFacade()
export class BookFacade {
  select = bindSelectors(selectors);
}

// component.ts
@Component({ /* ... */ })
export class BookComponent {
  books: Observable<Book[]>;

  constructor(private bookFacade: BookFacade) {
    this.books = this.bookFacade.select.books;
  }
}

Currently, I am not able to support selectors accepting props since I cannot differentiate at runtime if I have to deal with a plain selector or not.

It would be nice to enable NgRx Ducks supporting selectors having properties.

  constructor(private bookFacade: BookFacade) {
    this.books = this.bookFacade.select.booksByCategory('sci-fi');
  }

Other information:

• Related issue Using selectors with props co-IT/ngrx-ducks#33

Differentiating at runtime

In NgRx Ducks the building Blocks are tagged to be able to know at runtime what data structure is passed.
For tagging an enum is used:

export enum DucksIdentifier {
  Duck,
  DuckDispatcherPlain,
  DuckDispatcherPayload,
  DuckPickFunction
}

Maybe a selector-factory could also be tagged.

If accepted, I would be willing to submit a PR for this feature

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

[brandonroberts]

We've deprecated selectors with props, so closing for now