Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router-store): add provideRouterStore function #3532

Merged
merged 13 commits into from
Aug 24, 2022
Merged

feat(router-store): add provideRouterStore function #3532

merged 13 commits into from
Aug 24, 2022

Conversation

yharaskrik
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

RouterStore has to be initialized by the forRoot method the StoreRouterConnectingModule

Closes #3528

What is the new behavior?

Can use provideRouterStore(config) now to configure the router store

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Aug 15, 2022 •
edited

✅ Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 82ece09
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/63057e7ca3e1fb00085357ef

yharaskrik
yharaskrik commented Aug 15, 2022
View reviewed changes
angular.json Outdated Show resolved Hide resolved
@yharaskrik
Copy link
Contributor Author

Ok we should be good to go on this one!

brandonroberts
brandonroberts requested changes Aug 16, 2022
View reviewed changes
modules/router-store/src/init_router_store.ts Outdated Show resolved Hide resolved
modules/router-store/src/provide_router_store.ts Outdated Show resolved Hide resolved
angular.json Outdated Show resolved Hide resolved
markostanimirovic
markostanimirovic requested changes Aug 23, 2022
View reviewed changes
modules/router-store/src/init_router_store.ts Outdated Show resolved Hide resolved
modules/router-store/src/provide_router_store.ts Outdated Show resolved Hide resolved
modules/router-store/src/router_store_module.ts Outdated Show resolved Hide resolved
@yharaskrik yharaskrik force-pushed the jaybell/convert-router-store-to-provider-function branch from ba4e2a5 to 2ab35d4 Compare August 23, 2022 17:55
markostanimirovic
markostanimirovic approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Great work Jay!

One small suggestion regarding API docs:

modules/router-store/src/provide_router_store.ts Outdated Show resolved Hide resolved
@markostanimirovic markostanimirovic changed the title feat(router-store): add provider function for router store feat(router-store): add provideRouterStore function Aug 24, 2022
@yharaskrik @markostanimirovic
docs(router-store): update documentation for provider function
82ece09 
Co-authored-by: Marko Stanimirović <markostanimirovic95@gmail.com>
@brandonroberts brandonroberts merged commit 511b7cf into ngrx:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

@markostanimirovic markostanimirovic markostanimirovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RouterStore: Introduce Standalone API for NgRx RouterStore
3 participants
@yharaskrik @brandonroberts @markostanimirovic