Skip to content
This repository has been archived by the owner on Jul 27, 2018. It is now read-only.

Chrome extension chart is not refreshed properly when using instrumentOnlyWithExtension() #38

Closed
pmulac opened this issue Nov 8, 2016 · 2 comments

Comments

@pmulac
Copy link

pmulac commented Nov 8, 2016

Redux devtools chrome extension: 2.9.0
ngrx/store-devtools: 3.2.2

When my state changes, I expect the chart/graph in the chrome extension to update and reflect the new state. When I call StoreDevtoolsModule.instrumentStore({ monitor: useLogMonitor() }), passing the logMonitor from the accompanying StoreLogMonitorModule, all state changes are updated live in the chrome extension graph.

However, if I call StoreDevtoolsModule.instrumentOnlyWithExtension(), the chrome extension graph is not refreshed when the state changes. If I select another tab in the chrome extension and return to the graph tab, then the graph shows the correct state.

Can we have the live-refresh functionality for the graph without having to use a custom monitor? Right now I have to instrument with the custom ngrx logMonitor and place the <ngrx-store-log-monitor> component in my app to force the chart to refresh.

@zalmoxisus
Copy link
Contributor

The problem was that ngrx/store-devtools doesn't send monitorState (used by Chart Monitor) as redux-devtools does. Now the extension generates it from monitor reducers and should work in 2.10.0.

@pmulac
Copy link
Author

pmulac commented Nov 10, 2016

@zalmoxisus Thank you, with version 2.10.0, the extension's chart now refreshes properly when using instrumentOnlyWithExtension().

@pmulac pmulac closed this as completed Nov 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants